[logger] `log.debug` and `.trace` should prefer the lazy implementation · elastic/kibana#214725

(3 commenti) (0 reazioni) (0 assegnatari)TypeScript (8021 fork)batch import

Feature:LoggingTeam:Coregood first issue

Metriche repository

There are many places where we do patterns like log.debug(`${JSON.stringify({...})}`) in the Kibana code.

When the log level is set higher than debug, this implies unnecessary CPU blocks only to be discarded later.

We should audit all use cases like this and change them to the lazy form: ``````log.debug(() => ${JSON.stringify({...})})```.

@dgieselaar provided the following RegExp to find all use cases:

\.(?:debug|trace)\(\s*(?!((?:\([^)]*\)|\w+)\s*=>)).*?JSON\.stringify\s*\(

Please, bear in mind that some loggers don't support this. Make sure to only update the ones using the Logger from @kbn/logger.

Ideally, an autofixable ESlint rule would prevent this from happening again.

Direzione di ricerca: Utilizza la RegExp fornita per individuare tutte le chiamate log.debug e log.trace che usano JSON.stringify in modo eager. Sostituiscile con la forma lazy usando una callback. Assicurati che il logger provenga da @kbn/logger.
Tech stack: typescript
Dominio: backend
Tipo issue: Performance
Difficoltà: 3
Tempo stimato: Mezza giornata
Stato attività: Attiva
Chiarezza: Chiara
Prerequisiti: TypeScript
Adatta ai principianti: 70