[APM] Add more info to the "Number of items in this trace exceed what is displayed" (xpack.apm.waterfall.exceedsMax) EuiCallOut · elastic/kibana#118282

(10 commenti) (0 reazioni) (0 assegnatari)TypeScript (8021 fork)batch import

Team:obs-ux-infra_services - DEPRECATEDapm:waterfallenhancementgood first issuestale

Metriche repository

Star: (19.065 star)
Metriche merge PR: (Merge medio 1g 16h) (999 PR mergiate in 30 g)

Descrizione

Kibana version

7.15.1

Steps to Reproduce

set up a separate deployment's kibana to report into APM
pull up a trace for alerting:monitoring_alert_jvm_memory_usage (it's a taskManager run type)
check the trace sample, especially after some time has passed

Expected Behavior

When the number of items exceeds the setting xpack.apm.waterfall.exceedsMax we should display the message:

Number of items in this trace exceed the maximum configured value (100). Please configure xpack.apm.ui.maxTraceItems to increase this value. See docs for more details

Actual Behavior

Get a number of items exceed message like this:

Screen Shot 2021-11-11 at 13 15 56

To work around this I ended up just browsing the kibana code to find the setting (maxTraceItems). Once I had that I was able to google my way to https://www.elastic.co/guide/en/kibana/current/apm-settings-in-kibana.html

Implementation details

https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/server/routes/traces/get_trace_items.ts#L77

Guida contributor

Direzione di ricerca: Trova il componente EuiCallOut nella vista waterfall e aggiorna il suo messaggio includendo il nome dell'impostazione di configurazione (xpack.apm.ui.maxTraceItems) e un link alla documentazione. Il messaggio deve fare riferimento all'impostazione e suggerire di aumentarla.
Tech stack: typescriptreact
Dominio: full stack
Tipo issue: Funzionalità
Difficoltà: 1
Tempo stimato: Meno di 1 ora
Stato attività: Datata
Chiarezza: Chiara
Prerequisiti: GitKibana development setup
Adatta ai principianti: 85