Uncaught Error: Cannot get key code from the keyboard event. Keydown event without code on chrome

(11 commenti) (1 reazione) (0 assegnatari)TypeScript (2478 fork)batch import

help wantedkeybindings

Metriche repository

Star: (18.676 stelle)
Metriche merge PR: (Merge medio 15g 4h) (75 PR mergiate in 30 g)

Descrizione

Bug Description:

When I click a datalist option linked to an input on Chrome (not Firefox), a keydown event is triggered. This event does not have a key/code/keycode. I don't know if it is a bug of Chrome but in any case, the widget listens keydown events and tries to find the key. Exception is thrown here. The event should probably just be ignored in this case.

This error once happened with electron but it is probably not relevant anymore

Steps to Reproduce:

Create an input and link it with a datalist containing several options in Chrome.
Listen for keydown events.
Click an option
Observe that there is no key information in the event.

Additional Information

Operating System: Windows 10, Chrome 97
Theia Version: Last, 1.22 (browser)

Guida contributor

Direzione di ricerca: Ispeziona il gestore dell'evento keydown in keys.ts e aggiungi una protezione per gli eventi senza key/code/keycode.
Tech stack: typescript
Dominio: frontend
Tipo issue: Bug
Difficoltà: 2
Tempo stimato: 1-3 ore
Stato attività: Attiva
Chiarezza: Chiara
Prerequisiti: Git
Adatta ai principianti: 70