drewnoakes/metadata-extractor-dotnet
Implement TgaHeaderReader.TryExtract to not use exceptions as information
Aperta
#297 aperta il 7 giu 2021
help wanted
Metriche repository
- Star
- (1059 stelle)
- Metriche merge PR
- (Merge medio 11h 24m) (1 PR mergiata in 30 g)
Descrizione
The current implementation of TgaHeaderReader.TryExtract returns false from a catch block. It should, instead, use return values to indicate when extraction failed.
This is more relevant than it may seem at first, as the FileTypeDetector infrastructure uses this code path to detect whether a file is TGA or not (there is no easy way to detect TGA, so we just attempt an extraction). For bulk file processing, this exception can occur regularly. This makes debugging annoying, and can hurt performance.