Reconsider the exception type thrown when trying to open a directory as file
#70.275 aperta il 6 giu 2022
Metriche repository
- Star
- (17.886 star)
- Metriche merge PR
- (Merge medio 12g 11h) (661 PR mergiate in 30 g)
Descrizione
In FileSystem.Windows, as well as SafeFileHandle.Windows we have this comment:
However, when testing with native code on Windows 10, calling CreateFileA returns ERROR_PATH_NOT_FOUND for either C:\ or other normal directories.
So this causing behavior inconsistency on managed API again: when calling File.Open on C:\, it throws UnauthorizedException. When calling with other directories, it throws PathNotFoundException.
I didn't find any test for exceptions in System.IO.FileSystem.
Changing the exception thrown is technically breaking, but helps for consistency. Changing to an exception is already used for other circumstances won't break much.
We need to also examine Windows 7 and 8 behavior and the behavior of CreateFile2 and NtCreateFile. (Or if you can directly check it through Windows source code)