dotnet/runtime

Support cookie values with comma

Open

#58.773 aperta il 7 set 2021

Vedi su GitHub
 (34 commenti) (2 reazioni) (0 assegnatari)C# (5445 fork)batch import
area-System.Net.Httpbughelp wanted

Metriche repository

Star
 (17.886 star)
Metriche merge PR
 (Merge medio 12g 11h) (661 PR mergiate in 30 g)

Descrizione

The following code will fail.

cookieContainer.Add(new Cookie("foo", "ba,r", "/", "example.com"));
---> System.Net.CookieException: The 'Value'='ba,r' part of the cookie is invalid.

This means that c# does not allow commas, but major browsers (Chrome, Firefox) do.

Chrome, Edge, and Firefox are the ones that allow commas. The combined market share of these browsers is probably over 90%. This means that allowing commas is a de facto standard.

My opinion is that we should follow the de facto standards, not the standardization bodies, because our goal is not to follow standards, but to solve real problems.

We need to face this.


Similar discussion in Golang: https://github.com/golang/go/issues/7243

Guida contributor