dotnet/roslyn

NormalizeWhitespace incorrectly adds space after comma between omitted nodes

Aperta

#34.565 aperta il 28 mar 2019

 (2 commenti) (0 reazioni) (0 assegnatari)C# (4257 fork)batch import
Area-CompilersFeature Requesthelp wanted

Metriche repository

Star
 (20.414 stelle)
Metriche merge PR
 (Merge medio 6g 17h) (256 PR mergiate in 30 g)

Descrizione

Version Used: 3.0.0-beta4-final

Steps to Reproduce:

Run the following program:

using System;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using static Microsoft.CodeAnalysis.CSharp.SyntaxFactory;

class Program
{
    static void Main()
    {
        var type = ArrayType(PredefinedType(Token(SyntaxKind.IntKeyword)))
            .WithRankSpecifiers(SingletonList(ArrayRankSpecifier(
                SeparatedList<ExpressionSyntax>(
                    new[] { OmittedArraySizeExpression(), OmittedArraySizeExpression()}))));

        Console.WriteLine(type);
        Console.WriteLine(type.NormalizeWhitespace());

        var expression = TypeOfExpression(GenericName(Identifier("Dictionary"))
                .WithTypeArgumentList(TypeArgumentList(SeparatedList<TypeSyntax>(
                    new[] { OmittedTypeArgument(), OmittedTypeArgument()}))));

        Console.WriteLine(expression);
        Console.WriteLine(expression.NormalizeWhitespace());
    }
}

Expected Behavior:

NormalizeWhitespace does not add any whitespace here, so the program prints:

int[,]
int[,]
typeof(Dictionary<,>)
typeof(Dictionary<,>)

Actual Behavior:

int[,]
int[, ]
typeof(Dictionary<,>)
typeof(Dictionary<, >)

Guida contributor