dotnet/roslyn

"Remove redundant assignment" should remove extra blank lines between assignment and trivia

Aperta

#33.313 aperta il 12 feb 2019

 (0 commenti) (0 reazioni) (0 assegnatari)C# (4257 fork)batch import
Area-IDEBugIDE-CodeStylehelp wanted

Metriche repository

Star
 (20.414 stelle)
Metriche merge PR
 (Merge medio 6g 17h) (256 PR mergiate in 30 g)

Descrizione

"Remove redundant assignment" already removes extra blank lines between assignment and any additional code, so the following:

        static void Main(string[] args)
        {
            string foo = null;

			Console.WriteLine();

            foo = new string('A', 10);

            Console.WriteLine(foo);
        }

Will be (correctly) collapsed to:

        static void Main(string[] args)
        {
			Console.WriteLine();

            string foo = new string('A', 10);

            Console.WriteLine(foo);
        }

However, if its trivia, this doesn't occur:

        static void Main(string[] args)
        {
            string foo = null;

            // This is a comment

            foo = new string('A', 10);

            Console.WriteLine(foo);
        }

Gets changed to:

        static void Main(string[] args)
        {

            // This is a comment

            string foo = new string('A', 10);

            Console.WriteLine(foo);
        }

Hit this in this giant code review: https://devdiv.visualstudio.com/DevDiv/_git/CPS/pullrequest/163613?_a=overview.

Guida contributor