dotnet/roslyn

Consider having CopyRefAssembly inherit from Copy

Open

#19.103 aperta il 28 apr 2017

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)C# (4257 fork)batch import
Area-CompilersBughelp wanted

Metriche repository

Star
 (20.414 star)
Metriche merge PR
 (Merge medio 5g 21h) (286 PR mergiate in 30 g)

Descrizione

The new CopyRefAssembly task has logic to determine whether a reference assembly is logically identical by comparing MVIDs of the source and destination files. If the MVIDs do not match, it copies the source assembly to the destination path.

As currently implemented, this copy doesn't have all of the bells and whistles of the Copy task, which supports retries and special-cases a number of scenarios.

CopyRefAssembly could inherit from Copy, override Execute(), do its up-to-date checks, and then after deciding to copy, forward to base.Execute() to get all of the additional magic.

This came up when discussing https://github.com/Microsoft/msbuild/issues/1986 with @jeffkl.

@jcouv -- something to think about. Doesn't block the initial implementation, since no MSBuild change would be required to pick this up.

Guida contributor