dotnet/msbuild

UseHardlinksIfPossible, readonly attributes and TFS issue

Open

#473 aperta il 9 feb 2016

Vedi su GitHub
 (1 commento) (1 reazione) (0 assegnatari)C# (1364 fork)batch import
help wantedtriaged

Metriche repository

Star
 (5062 star)
Metriche merge PR
 (Merge medio 11g 7h) (125 PR mergiate in 30 g)

Descrizione

Microsoft.Build.Tasks.Copy supports UseHardlinksIfPossible property. Unfortunately, using this property causes the issue with coping the files originally located at TFS (workspace location should be set to Server). This task clears all attributes of a destination files, but in case of hard link original and destination files are the same, so original files also changes their attributes (especially readonly one).

And next time on updating TFS can cause conflicting issue, because in Server mode workspace lack of readonly attribute means that the file has been changed and needed for merging.

I'd advise to perform small change at 351 line of Cope.cs file, something like this:

if (sourceFileState.IsReadOnly && !hardLinkCreated)

Or better implement additional property which will indicate what we should do with hard links attributes.

Guida contributor