dotnet/aspnetcore

TestServer.CreateClient : the HttpClient created didn't support well the cancellation.

Open

#5938 aperta il 17 set 2018

Vedi su GitHub
 (4 commenti) (1 reazione) (0 assegnatari)C# (10.653 fork)batch import
affected-fewarea-hostingarea-networkingbughelp wantedseverity-minor

Metriche repository

Star
 (37.933 star)
Metriche merge PR
 (Merge medio 16g 9h) (258 PR mergiate in 30 g)

Descrizione

Hello,

I just found a nasty bug on HttpClient created from TestServer. When I call a request which took 2 seconds if I cancel it after one second. The client created by test server didn't throw an OperationCancelledException.

Here the code with real httpClient :

var httpClient = new HttpClient();
using (var cts = new CancellationTokenSource(TimeSpan.FromSeconds(1)))
{
    var request = new HttpRequestMessage
    {
        Method = HttpMethod.Get,
        RequestUri = new Uri("http://localhost:4242/TimeoutTest/Action2Secs")
     };
     await httpClient.SendAsync(request, HttpCompletionOption.ResponseContentRead, cts.Token);
}

The same code with client created by the class TestServer.

var httpClient = new testServer.CreateClient();
using (var cts = new CancellationTokenSource(TimeSpan.FromSeconds(1)))
{
    var request = new HttpRequestMessage
    {
        Method = HttpMethod.Get,
        RequestUri = new Uri("http://localhost:4242/TimeoutTest/Action2Secs")
     };
     await httpClient.SendAsync(request, HttpCompletionOption.ResponseContentRead, cts.Token);
}

Guida contributor