dotnet/aspnetcore

Short circuit attribute

Chiusa

#49.181 aperta il 3 lug 2023

 (12 commenti) (2 reazioni) (1 assegnatario)C# (10.653 fork)batch import
api-approvedarea-middlewarehelp wanted

Metriche repository

Star
 (37.933 stelle)
Metriche merge PR
 (Merge medio 16g 9h) (258 PR mergiate in 30 g)

Descrizione

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

The short circuit feature only has extension methods for adding the required metadata to endpoints. Should there be an attribute? That would allow MVC actions and gRPC methods to support short circuiting.

For example,

public class MonitoringController
{
    [ShortCircuit]
    [HttpGet("/status")]
    public ActionResult GetStatus()
    {
        // ...
    }
}

Brought up in YouTube video: https://youtu.be/rXdwX2X4-gw?t=422

Note that a short-circuited MVC action would still execute filters, and a gRPC method would still execute interceptors.

Describe the solution you'd like

  • Change internal ShortCircuitMetadata to an interface. (optional)
  • Change current metadata to an attribute and make public (implement the interface if present)

Additional context

No response

Guida contributor