dotnet/aspnetcore

Misleading TaskCanceledException

Aperta

#4747 aperta il 30 mag 2018

 (7 commenti) (0 reazioni) (0 assegnatari)C# (10.653 fork)batch import
affected-very-fewarea-networkingbugfeature-kestrelhelp wantedseverity-nice-to-have

Metriche repository

Star
 (37.933 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

I have a WebApi endpoint that parses out the Request.Body itself rather than using Model binding due to performance reasons.

During some requests, I was getting a TaskCanceledException from a TextReader that I never gave any CancellationTokens too. After investigation, I found out that any read operations on the Request.Body after the Request was aborted will throw TaskCanceledExceptions. The stack trace at the time didn't list any Kestrel level code so I spent a lot of time trying to find out how a Stream can possibly cancel a token I never gave it.

This is a bit misleading and should probably change I think.

Guida contributor