dotnet/aspnetcore

Suggestion: Expose a parameter of `ShouldMatch` for `<NavLink />`

Chiusa

#18.163 aperta il 7 gen 2020

 (6 commenti) (1 reazione) (0 assegnatari)C# (10.653 fork)batch import
Priority:1affected-fewarea-blazorenhancementfeature-blazor-builtin-componentshelp wantedseverity-minor

Metriche repository

Star
 (37.933 stelle)
Metriche merge PR
 (Merge medio 16g 9h) (258 PR mergiate in 30 g)

Descrizione

Is your feature request related to a problem? Please describe.

I want to custom the matching behavior of <NavLink />.

Let's say we want to process a url with a hash(See this thread on SO) :

http://localhost/#an-element-id

Sometimes we might think this url matches http://localhost , while some other users don't think so.

It would be great if we are allowed to custom this matching behavior. Usually, we can custom by inheritance or composition. However, the matching logic is hardcoded for the present.

  1. There's no public/protected ShouldMatch(string) method exposed. So it's difficult to achieve it by inheritance
  2. There's no ShouldMatch parameter exposed. It would be great if we can pass a ShouldMatch [Parameter] to this component.

Describe the solution you'd like

Expose a [Parameter] of ShouldMatch(string):

  • if user provides such a parameter, use it.
  • Otherwise, use the default logic.

Guida contributor