dlt-hub/dlt

make the use of `loader_file_format` parameter consistent

Aperta

#815 aperta il 11 dic 2023

 (4 commenti) (0 reazioni) (0 assegnatari)Python (589 fork)github user discovery
QoLgood first issue

Metriche repository

Star
 (5765 stelle)
Metriche merge PR
 (Merge medio 7g 7h) (54 PR mergiate in 30 g)

Descrizione

Background The loader_file_format can be configured on the pipeline level and this is fine. But technically it is a normalize setting and we should be able to configure it there as well.

Also not all data types are supported by all formats on all destinations. We should detect those and fail early.

Tasks

    • add loader_file_format to normalize configuration and use it to set the file format. If the explicit value is passed from the pipeline, it has the precedence.
    • add the exceptions to destination capabilities where we declare unsupported types per file format. Take the current cases from particular destination code (ie Bigquery and Snowflake have plenty of exceptions)
    • detect such exceptions in normalize (preferably in worker: before updating a schema check if any type is on exception list and raise exception with an explanation)
    • the behavior above must be tested

Guida contributor