django/djangoproject.com

fundraising: 'customer.subscription.deleted' webhook event always gets 404 response

Open

Aperta il 4 mag 2017

Vedi su GitHub
 (5 commenti) (0 reazioni) (0 assegnatari)Python (2001 star) (1100 fork)user submission
bugfundraisinggood first issue

Descrizione

The response to stripe 'customer.subscription.deleted' webhook event is always 404. The reason is:

In the cancel_donation view, stripe_subscription_id is set to an empty string https://github.com/django/djangoproject.com/blob/e5a4bf20fb58c463441c15d552c022b03f716858/fundraising/views.py#L178

In the subscription_cancelled webhook handler method, the donation object is fetched using stripe_subscription_id which was set to an empty string earlier.

https://github.com/django/djangoproject.com/blob/e5a4bf20fb58c463441c15d552c022b03f716858/fundraising/views.py#L232-L233

So, the response will always be 404 and no cancellation email will be sent to the donor.

Guida contributor

Tech stack
python
Dominio
backendpayments
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
DjangoStripe APIPython
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
The bug is in fundraising/views.py. In the cancel donation view, stripe subscription id is set to an empty string at line 178. The subscription cancelled webhook handler at lines 232-233 uses that empty id to fetch the donation, resulting in a 404. To fix, ensure the subscription id is retained until after the webhook is processed, or handle the case where the subscription id is cleared. This is a small localized change that a newcomer can implement.