diegomura/react-pdf

Some borders draw faint pencil-like artefacts

Open

Aperta il 29 ago 2019

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)JavaScript (13.687 star) (1116 fork)batch import
help wanted

Descrizione

Describe the bug Some borders get slight artefacts at the outer edges and through the corners of the border, which almost look like faint pencil strokes. In the example below, it happens around the dark boxes, but not around the light boxes (at least not visibly so). Zoom in on the generated PDF to see it in action.

To Reproduce Reproduced in this REPL snippet

Expected behavior Those artefacts should not appear.

Screenshots

Desktop:

  • OS: MacOS 10.13.6
  • Browser N/A, but verified in the Preview.app PDF viewer and in Safari and Chrome's PDF viewers.
  • React-pdf version v1.6.4

Guida contributor

Tech stack
reactjavascript
Dominio
frontend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
4
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
ReactJavaScriptPDF rendering concepts
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
Investigate the border rendering code in react pdf, likely in the styling or layout modules. The issue reproduces in the provided REPL snippet. Start by examining how borders are drawn for elements, particularly those with dark backgrounds. Look for any coordinate rounding or anti aliasing logic that might cause faint lines. Check the underlying pdfkit library if the issue stems from there. Also consider testing with different border widths and colors to isolate the problem.