dice-roller/rpg-dice-roller

Issues with module's types

Aperta

#247 aperta il 1 apr 2022

 (4 commenti) (0 reazioni) (0 assegnatari)JavaScript (68 fork)auto 404
bughelp wanted

Metriche repository

Star
 (279 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Describe the bug Some of the type definitions seems to be faulty or incomplete.

To Reproduce Steps to reproduce the behaviour:

  1. Bootstrap a new typescript project with the defaults (npm i typescript --save-dev && npx tsc --init)
  2. Install the module via npm (npm install @dice-roller/rpg-dice-roller)
  3. Create an example file index.ts (see below)
  4. Set skipLibCheck to false in tsconfig.json
  5. Run tsc to build the project

Expected behaviour No type errors show up.

Code snippet

import { DiceRoll } from "@dice-roller/rpg-dice-roller"

const roller = new DiceRoll("6d6")

console.log(roller.toString())

Environment:

  • Node.js 17.3.0 on Windows 10 & Node.js 16.14.2 on Ubuntu 20.04.4 installed from nodesource
  • Module version 5.1.0, 5.0.0 has the same behaviour

Guida contributor