diasurgical/DevilutionX
Port fixes for multiplayer dsync from Pioners fork
Aperta
#2725 aperta il 27 ago 2021
help wanted
Metriche repository
- Star
- (7255 stelle)
- Metriche merge PR
- (Merge medio 2g 12h) (15 PR mergiate in 30 g)
Descrizione
Describe @pionere has a lot of interesting in his port, one of the major parts is some new network update logic to reduce desync
This is mainly done via the following commit: https://github.com/diasurgical/devilutionX/commit/bcbef3afa45e36cbe4fc233ff8261553bf25073e
Porting this is complicated a bit by large part of the fork still using an holder iteration of the code and a different code style, but it should still be reasonably to do so.
Steps
- Go over the commit and get a good feel for the semantic changes, and separate it from the style changes.
- Start applying the same changes to the code
- Run two clients on your local system and run a TCP game where you test multiplayer works as intended
- Create a pull request with the backported code
Expected behavior It might be a good idea to also test this on the fork before starting the process to get a good feel for how it works and now to verify it.