delta-io/delta

[Feature Request]Fix potential float -> double casting issue and align in expression with comparator "=" implementation

Open

#5227 aperta il 17 set 2025

Vedi su GitHub
 (6 commenti) (0 reazioni) (1 assegnatario)Scala (2100 fork)batch import
enhancementgood first issuekernel

Metriche repository

Star
 (8807 star)
Metriche merge PR
 (Merge medio 7g 1h) (142 PR mergiate in 30 g)

Descrizione

Feature request

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Overview

In https://github.com/delta-io/delta/pull/5186, we are kind of customizing the type check and value comparison among numerics.

Technically we could streamline the implementation via a refactor to 1.figure out the narrowest type 2.transform the expression via implicit cast expression 3.simplify the value comparision.

Doing so today will have 1 test failure fails due to float -> double convertion 84.08 -> 84.08000183105469 We need to investigate this logic in implicit cast and then do refactoring to unify the expression logic

Motivation

Further details

Willingness to contribute

The Delta Lake Community encourages new feature contributions. Would you or another member of your organization be willing to contribute an implementation of this feature?

  • Yes. I can contribute this feature independently.
  • Yes. I would be willing to contribute this feature with guidance from the Delta Lake community.
  • No. I cannot contribute this feature at this time.

Guida contributor