decentralized-identity/ion
Vedi su GitHubBitcoinClient should check for if the 'bitcoinWalletOrImportString' parameter is undefined
Open
#314 aperta il 20 apr 2020
good first issue
Metriche repository
- Star
- (1219 star)
- Metriche merge PR
- (Nessuna PR mergiata in 30 g)
Descrizione
If the admin forgets to add in either the import string or an actual IBitcoinWallet on this parameter then we should throw here. Currently, the this.bitcoinWallet member stays undefined and we throw when we try to use it.
Suggestion:
if (typeof bitcoinWalletOrImportString === 'undefined') { // throw }
// OR
// After all the initializations
if (this.bitcoinWallet === undefined) { // throw }