danielebogo/DBPrivacyHelper

Locale support

Open

#23 aperta il 24 nov 2015

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Objective-C (58 fork)github user discovery
Hacktoberfest

Metriche repository

Star
 (430 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Our project currently only supports one language, but upon integrating your pod, now it claims to support a myriad: Italian, Japanese, Korean, Portuguese, Spanish, and Traditional Chinese. I'm glad it has this capability, but I think you would agree that your pod shouldn't dictate what languages our app supports. :)

The solution appears to be thus, from a similar example with a Git project Appirater:

Afaik, this is only because Appirater adds all those localization bundles in the root of your app’s bundle. It should not do that. It should have a namespaced resource bundle that contains them and adjust the code accordingly.

As it is now, you can’t even have your own localizations without merging them with those of Appirater, which is bad.

https://github.com/CocoaPods/CocoaPods/issues/1301#issuecomment-22926515

Any help with this would be greatly appreciated!

Guida contributor