dOrgTech/DAOcreator

`initStateStore` - Don't Assume LocalStorage

Aperta

#243 aperta il 17 nov 2019

 (0 commenti) (0 reazioni) (0 assegnatari)TypeScript (18 fork)auto 404
Libcode improvementgood first issuemed pri

Metriche repository

Star
 (34 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Currently we've hard-coded our state persistence into the UI layer and are using the localStorage of the browser. We should instead be making API calls into the Lib layer, and using an interface the implementer of the library supplies upon initialization.

For example:

import { initStateStore } from "lib/state";

// localStorage in browser, file in CLI
setStateStore({
  getItem: (key: string) => { ... },
  setItem: (key: string, value: string) => { ... },
  clearItem: (key: string) => { ... }
});

// later in the application
getSavedDAO();
saveDAO(dao);

Guida contributor