conventional-changelog/conventional-changelog

Links in CHANGELOG.md files are broken when using conventional commits

Open

#357 aperta il 6 ago 2018

Vedi su GitHub
 (3 commenti) (9 reazioni) (0 assegnatari)JavaScript (722 fork)batch import
defecthelp wanted

Metriche repository

Star
 (7282 star)
Metriche merge PR
 (Merge medio 3m) (1 PR mergiata in 30 g)

Descrizione

I am using conventional-changelog-core through lerna and noticed that links in my CHANGELOG.md files are broken when releasing packages with lerna publish.

Context

At Wire we have a monorepo that we manage with lerna. In our monorepo there are several packages within a folder called "packages". To release all packages we run the following command:

lerna publish -m "[skip ci] chore: Publish" --conventional-commits --loglevel=verbose --exact --allow-branch=master --registry=https://registry.npmjs.org/ --yes

The command above creates a release version for every package and adds CHANGELOG.md files to the directories of the individual packages. Unfortunately all the links in that CHANGELOG are broken because they include "tree/master/packages/package-name".

Live Example:

Broken Links:

https://github.com/wireapp/wire-web-packages/tree/master/packages/react-ui-kit/compare/@wireapp/react-ui-kit@2.1.3...@wireapp/react-ui-kit@2.2.0
https://github.com/wireapp/wire-web-packages/tree/master/packages/react-ui-kit/issues/936
https://github.com/wireapp/wire-web-packages/tree/master/packages/react-ui-kit/commit/def55c0

Correct Links:

https://github.com/wireapp/wire-web-packages/compare/@wireapp/react-ui-kit@2.1.3...@wireapp/react-ui-kit@2.2.0
https://github.com/wireapp/wire-web-packages/issues/936
https://github.com/wireapp/wire-web-packages/commit/def55c0

I flagged that issue to lerna but the team says that they are just passing arguments to conventional-changelog-core. So is this a "conventional-changelog" error?

Guida contributor