conventional-changelog/commitlint

Error when working from within a branch worktree

Chiusa

#787 aperta il 13 set 2019

Vedi su GitHubGuida contributor
 (13 commenti) (0 reazioni) (0 assegnatari)TypeScript (896 fork)batch import
bughelp wanted

Metriche repository

Star
 (15.497 stelle)
Metriche merge PR
 (Merge medio 12h 56m) (52 PR mergiate in 30 g)

Descrizione

When trying to run commitlint from within a branch worktree directory, I get the following error: could not find git root from undefined

Expected Behavior

The operation should succeed without error.

Current Behavior

The operation errors with could not find git root from undefined

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Steps to Reproduce (for bugs)

  1. Checkout a repo
  2. Checkout a different branch into a separate folder via worktree: git worktree add -b my-branch ../my-branch
  3. CD into the branch folder
  4. Make some changers
  5. Try to commit

Your Environment

Executable Version
commitlint --version 8.1.0
git --version git version 2.20.1.windows.1
node --version v10.14.1

Guida contributor

Direzione di ricerca
Investigate how commitlint resolves the git root. The error suggests that the git root detection returns undefined in worktree directories. Check the source code in the CLI package, likely in the `@commitlint/cli` or `@commitlint/load` module, where `git rev parse show toplevel` is called. Consider using ` git common dir` or ` path format` to handle worktrees. Refer to linked PRs or comments for prior discussion. Also examine existing tests for git root resolution.
Tech stack
typescript
Dominio
cli
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
Mezza giornata
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
git worktree conceptcommitlint internalsTypeScript
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60