conventional-changelog/commitlint

fix: `body-max-line-length` is not respecting `footer-max-line-length` and failing for long footers

Aperta

#4088 aperta il 12 giu 2024

 (1 commento) (0 reazioni) (0 assegnatari)TypeScript (896 fork)batch import
bughelp wanted

Metriche repository

Star
 (15.497 stelle)
Metriche merge PR
 (Merge medio 12h 56m) (52 PR mergiate in 30 g)

Descrizione

Steps to Reproduce

1. First step
set rules 

{
  "body-max-line-length": [2, "always", 100],
  "footer-max-line-length": [2, "always", 150],
}

2. Second step
In commit have a footer greater than 100 characters and less than 150 characters

Current Behavior

The commitlint fails with body-max-line-length

Expected Behavior

It shouldn't fail with body-max-line-length as footer-max-line-length is respected

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

No response

Context

Am facing this issue when using the commitlint-pre-commit-hook plugin for pre-commit.

Have current suppressed the checks with the following config

module.exports = {
    extends: ['@commitlint/config-conventional'],
    rules: {
        'body-max-line-length': [0, 'always', 0],
        'footer-max-line-length': [0, 'always', 0],
    }
};

commitlint --version

@commitlint/cli@19.3.0

git --version

v2.39.3

node --version

v12.22.12

Guida contributor