conductor-oss/conductor

APIs throwing 500 status when 4** is expected

Open

Aperta il 28 mag 2024

Vedi su GitHub
 (7 commenti) (0 reazioni) (2 assegnatari)Java (31.816 star) (894 fork)batch import
bughelp wanted

Descrizione

Describe the bug When trying to delete a non-existing workflow using DELETE {{conductorBaseUrl}}/api/metadata/workflow/:name/:version api replies back with 500 status code.

{
    "status": 500,
    "message": "No such workflow definition: memes_maker version: 2",
    "instance": "1a79daf01f84",
    "retryable": false
}

Details Conductor version: v3.19.0 Persistence implementation: Postgres Queue implementation: Postgres Lock: I guess redis

To Reproduce Steps to reproduce the behavior:

  1. Use API to delete non existing workflow
curl --location --request DELETE 'http://localhost8080/api/metadata/workflow/memes_maker/2'
  1. See error

Expected behavior Status code should be 404

Additional context Same thing happens if we try to create existing workflow with existing version.

Guida contributor

Tech stack
javaspring
Dominio
backendapi
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
active
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Nessuno
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
80
Direzione di ricerca
The issue is that the DELETE endpoint for non existing workflow definitions returns a 500 status code instead of 404. Look at the workflow metadata resource controller (likely in a class like WorkflowMetadataResource.java) and find the delete method. The exception handling for 'No such workflow definition' should be caught and returned as a 404 response. The fix is simple: change the error response status from 500 to 404. The relevant code is probably in the Conductor server module.