codex-team/editor.js

CSS overriding the style of block tool SVG component

Open

#2294 aperta il 3 mar 2023

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)TypeScript (1985 fork)batch import
good first issueimportant

Metriche repository

Star
 (26.602 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

There is a css rule in file ui.css, which goes like this...

path { stroke: currentColor; }

Now this rule is fairly innocent but when you have some SVG component as a Block tool, in my case, I am rendering Echarts as a block tool which uses SVG. Then this rules completely overtakes the styles of my svg->path element. Check this image below.

Screenshot 2023-03-03 at 6 04 03 PM

For this SVG, the stroke gets overridden by editor.js style...

Screenshot 2023-03-03 at 6 09 30 PM

This happens because SVGs style precendence works bit differently, Link

The presentation attributes thus will participate in the CSS2 cascade as if they were replaced by corresponding CSS style rules placed at the start of the author style sheet with a specificity of zero. In general, this means that the presentation attributes have lower priority than other CSS style rules specified in author style sheets or ‘style’ attributes.

There is no way to override this behaviour, So I am suggesting if ui.css style could be bit scoped, then this issue could be avoided.

Thanks in advance guys, up and up

Guida contributor