codeigniter4/CodeIgniter4

Dev: replace type `mixed` with more specific types

Open

Aperta il 29 lug 2022

Vedi su GitHub
 (11 commenti) (0 reazioni) (0 assegnatari)PHP (4492 star) (1707 fork)batch import
devgood first issuehelp wanted

Descrizione

Type mixed means object|resource|array|string|int|float|bool|null. https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.mixed

The current code base has a lot of type mixed in PHPDocs, But I think all of them are not correct.

And mixed prevents PHPStan level from increasing.

PHPStan’s rule level 6 isn’t satisfied with implicit mixed https://phpstan.org/writing-php-code/phpdoc-types#mixed

We need to replace type mixed with more specific types.

Guida contributor

Tech stack
Nessuno
Dominio
backend
Tipo issue
refactor
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
PHP basicsunderstanding of PHPDoc type declarationsfamiliarity with PHPStan
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
Search the codebase for occurrences of `mixed` in PHPDoc comments (e.g., using grep or an IDE). Replace each with the most specific type as per PHP documentation (e.g., `string`, `int`, `array`). Refer to PHPStan's rule level 6 expectations. No linked PRs or maintainer questions as of now.