clawwork-ai/ClawWork
Vedi su GitHub[Enhancement] Add unit tests for GatewayDispatcher error handling logic
Open
#227 aperta il 1 apr 2026
area/dxarea/gatewayenhancementhelp wanted
Metriche repository
- Star
- (519 star)
- Metriche merge PR
- (Metriche PR in attesa)
Descrizione
What problem are you trying to solve?
GatewayDispatcher contains critical error deduplication and lifecycle buffering logic (shouldDisplayError, isSameFailure, lifecycleErrorBuffer) that currently has zero test coverage. These are some of the most bug-prone code paths in the app — they handle error display, deduplication, and a 2-second buffering window — but any regression would go unnoticed.
Where
- Source:
packages/core/src/services/gateway-dispatcher.ts - Test directory:
packages/core/currently has notest/directory — you will need to create one
What needs to be done
- Create
packages/core/test/gateway-dispatcher.test.ts - Extract
shouldDisplayErrorandisSameFailureas pure testable functions (or test them through the dispatcher) - Write tests covering:
isSameFailure: returns true for identical error codes/messages, false for different onesshouldDisplayError: respects the lifecycle error buffer (errors within the 2s window after a lifecycle event are suppressed)shouldDisplayError: does not suppress errors whenchat.stateis alreadyerror- The buffer timer: after 2s, buffered errors are released
- Use
vi.useFakeTimers()for the buffer window tests - Run
pnpm checkto verify
Why does this matter?
Error display logic is invisible when it works and catastrophic when it breaks — users either get spammed with duplicate errors or see no errors at all. Tests here prevent both failure modes.
Primary area
Task execution