catchorg/Catch2

Refactor and centralize compiler detection

Aperta

#2094 aperta il 3 nov 2020

 (12 commenti) (0 reazioni) (0 assegnatari)C++ (3228 fork)batch import
DevelopmentGood First IssueTweak request

Metriche repository

Star
 (20.381 stelle)
Metriche merge PR
 (Merge medio 1g 8h) (1 PR mergiata in 30 g)

Descrizione

Currently Catch2 detects compilers ad-hoc, at the place where the code needs to be compiler-specific. This brings a lot of trouble with more obscure compilers, because compilers like to masquerade for different compilers, such as Clang defining GCC-version macros, ICC defining both, IBM XL self-reporting as Clang, and so on. Because compiler-specific sections of code are often indeed compiler-specific, not detecting compilers properly can be a problem, e.g. Clang will complain that it found unknown pragma if we try to disable GCC-specific warning without checking that Clang is not used.

The solution is to perform more rigorous compiler detection, and centralize it, so that updates don't have to be done in multiple places.

Guida contributor