carla-simulator/carla

port(streaming): ServerSession::CloseNow idempotency fix to ue5-dev

Chiusa

#9759 aperta il 27 mag 2026

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)C++ (3227 fork)batch import
Good community contribgood first issue

Metriche repository

Star
 (10.105 stelle)
Metriche merge PR
 (Merge medio 17g 10h) (21 PR mergiate in 30 g)

Descrizione

Context

PR #9740 fixed a double-close race in ServerSession::CloseNow() on ue4-dev when two async paths (deadline timer + a failing write) both triggered a close for the same session, _on_closed() -> DisconnectSession() was called twice, silently evicting a still-alive subscriber from the world-snapshot stream.

The fix adds std::atomic_bool _is_closed{false} to ServerSession and guards CloseNow() with _is_closed.exchange(true) so the close path runs exactly once.

Task

Port the fix from ue4-dev to ue5-dev.

Files to update:

  • LibCarla/source/carla/streaming/detail/tcp/ServerSession.h
  • LibCarla/source/carla/streaming/detail/tcp/ServerSession.cpp

References

  • Fix: #9740

Guida contributor

Direzione di ricerca
Review PR #9740 on ue4 dev to understand the double close race fix. Then apply the same changes to ue5 dev: add `std::atomic bool is closed{false}` to ServerSession.h and guard `CloseNow()` with ` is closed.exchange(true)` in ServerSession.cpp. Verify no branch specific differences affect the fix.
Tech stack
cpp
Dominio
backend
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
Meno di 1 ora
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Nuova
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
C++atomic operationsCARLA streaming subsystem
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
85