cake-build/cake

TFBuild.IsRunningOnVSTS is confusing when using own build agent

Open

#1580 aperta il 23 apr 2017

Vedi su GitHub
 (5 commenti) (0 reazioni) (0 assegnatari)C# (738 fork)batch import
Help wantedImprovementUp-for-grabs

Metriche repository

Star
 (3742 star)
Metriche merge PR
 (Merge medio 1g 1h) (25 PR mergiate in 30 g)

Descrizione

What You Are Seeing?

I have a VSTS build agent, which is triggering a cake build on GitHub commits.

I tried using the TFBuild.IsRunningOnVSTS to check if this was a build running on VSTS, as I am also using AppVeyor.

What is Expected?

I would have expected TFBuild.IsRunningOnVSTS to return true. It returned false.

This seems to be per design as seen in the TFBuildProvider

What version of Cake are you using?

Latest

I discussed this briefly with @patriksvensson on Gitter and we kind of agreed that the IsRunningOnVSTS and IsRunningOnTFS properties could be a bit misleading.

@patriksvensson suggested a possible rename:

IsRunningOnVSTS -> IsRunningOnSharedAgent IsRunningOnTFS -> IsRunningOnOwnAgent

To me this would be much more clear as VSTS can both run shared and own agents.

@agc93 you seem to be the original author of this feature, what do you think about this?

Guida contributor

Direzione di ricerca
Studia la classe TFBuildProvider e il suo utilizzo in tutto il codebase. Determina dove vengono utilizzati IsRunningOnVSTS e IsRunningOnTFS e pianifica una ridenominazione rispettivamente in IsRunningOnSharedAgent e IsRunningOnOwnAgent.
Tech stack
csharp
Dominio
build system
Tipo issue
Refactoring
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 ore
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Attiva
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
GitC#
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
75