cake-build/cake

Automatic argument retrieval with fallback mechanism

Open

#1265 aperta il 10 ott 2016

Vedi su GitHub
 (7 commenti) (0 reazioni) (0 assegnatari)C# (738 fork)batch import
Good first issueHelp wantedImprovementUp-for-grabs

Metriche repository

Star
 (3742 star)
Metriche merge PR
 (Merge medio 1g 1h) (25 PR mergiate in 30 g)

Descrizione

For my own purposes I have created this convenience method. It checks for argument values in the following order:

  1. Specified via command line
  2. Specified via build server (build server variable)
  3. Specified via environment variable

This way we need less explicit variable definitions because most of them are automatically retrieved from the build server (in most cases, people are running cake from a build server and pass in variables already defined in the build server).

It's currently written for continua ci only, but this can easily be extended to other build servers as well and renamed to GetVariable

public string GetContinuaCIVariable(string variableName, string defaultValue)
{
    var argumentValue = Argument(variableName, "non-existing");
    if (argumentValue != "non-existing")
    {
        Information("Variable '{0}' is specified via an argument", variableName);

        return argumentValue;
    }

    if (ContinuaCI.IsRunningOnContinuaCI)
    {
        var buildServerVariables = ContinuaCI.Environment.Variable;
        if (buildServerVariables.ContainsKey(variableName))
        {
            Information("Variable '{0}' is specified via Continua CI", variableName);

            return buildServerVariables[variableName];
        }
    }

    if (HasEnvironmentVariable(variableName))
    {
        Information("Variable '{0}' is specified via an environment variable", variableName);

        return EnvironmentVariable(variableName);
    }

    Information("Variable '{0}' is not specified, returning default value", variableName);    

    return defaultValue;
}

What do you think, is it worth PR-ing?

Guida contributor