boot-clj/boot

Consider Reader Support For File Objects

Open

#250 aperta il 13 lug 2015

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Clojure (178 fork)batch import
Enhancementhelp wanted

Metriche repository

Star
 (1748 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

were it not for the File object on :dir in the TmpFile record, tmpfiles could be passed directly into pods.

#boot.tmpdir.TmpFile{:dir #object[java.io.File 0x5577160d[/Users/me/.boot/cache/tmp/Users/me/Development/apps/myapp/joo/7o2s6s], :path "js/myscript.js", :id "fe1bd08f4351c143197a11cf777ef047", :time 1436124119000}

storing the directory as a string instead makes this possible:

(defn marshall-tmpfile [tmpfile] (update tmpfile :dir #(.getPath %)))

#boot.tmpdir.TmpFile{:dir "/Users/me/.boot/cache/tmp/Users/me/Development/apps/myapp/joo/7o2s6s", :path "js/myscript.js", :id "fe1bd08f4351c143197a11cf777ef047", :time 1436124119000}

it would be an improvement, for my case, to store the TmpFile :dir as a string instead of a File, or perhaps more generally, add reader support for File types to the pod machinery.

Guida contributor