bodil/purescript-signal

Unnecessary recalculation?

Open

#44 aperta il 28 apr 2016

Vedi su GitHub
 (3 commenti) (2 reazioni) (0 assegnatari)PureScript (41 fork)github user discovery
enhancementhelp wanted

Metriche repository

Star
 (260 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Hi, I'm evaluating several FRP solutions for a large-scale project and have been diving into the source code for this library. First of all, kudos for a great library, it's been working great with the prototypes I've been playing with and I'm greatly enjoying using it.

There's one point I don't understand - in the Elm implementation of FRP, signals pass an 'updated' flag through the signal graph to avoid unnecessary recalculation (see from page 28 in Czaplicki's original paper, and the original implementation of Elm's signals).

However, I can't seem to find this mechanism in the purescript-signal code - the entire signal graph seems to be updated for every input. Is there a reason for this, and would you accept a pull request to add it to the library?

Guida contributor