awslabs/benchmark-ai

R.E.S.P.E.C.T Makefile Targets!!!!

Aperta

#634 aperta il 25 lug 2019

 (0 commenti) (0 reazioni) (1 assegnatario)Python (6 fork)auto 404
documentationenhancementgood first issue

Metriche repository

Star
 (19 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Let's go through and make sure that everything can be built with make and that they all have these targets:

clean-all -> [build -> test] -> [package -> publish] -> deploy

The brackets indicate where dependencies are allowed. So for build you may build and test For publish, you may depend on making sure publishable artifacts are packaged. The contract for "clean-all" is that it guarantees that there are not superfluous artifacts in the tree. (everyone should have a "clean" but it is not being mandated here).

Please check through all the Makefiles so that they behave appropriately.

  • ./baictl/Makefile
  • ./bff/Makefile
  • ./blackbox-tests/Makefile **
  • ./client-lib/Makefile
  • ./executor/integration_tests/Makefile
  • ./executor/Makefile
  • ./fetcher/integration_tests/Makefile
  • ./fetcher/Makefile
  • ./fetcher/mock-fetcher-job/Makefile **
  • ./fetcher-job/Makefile
  • ./kafka-utils/integration_tests/Makefile
  • ./kafka-utils/Makefile
  • ./metrics-extractor/Makefile
  • ./metrics-pusher/Makefile
  • ./prometheus-kafka-topic-exporter/Makefile
  • ./puller/Makefile
  • ./sm-executor/Makefile
  • ./watcher/Makefile

** make sure that they behave appropriately, and output something that makes sense to the caller

Guida contributor