appsmithorg/appsmith

(JS-0458) Definitions for unused states detected

Open

Aperta il 29 set 2021

Vedi su GitHub
 (20 commenti) (0 reazioni) (1 assegnatario)TypeScript (39.454 star) (4508 fork)batch import
Good First IssueLow effortTask

Descrizione

Description

You should avoid defining states that are not being used because unused states might affect while refactoring the codebase and introduces unnecessary operations by ReactJS. It is recommended to plan the behavior and operation of the component.

Occurrences

There are 9 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/appsmithorg/appsmith/issue/JS-0458/occurrences/

Guida contributor

Tech stack
typescriptreact
Dominio
frontend
Tipo issue
refactor
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
active
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic React knowledgeUnderstanding of component stateFamiliarity with code editing
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
Review the 9 occurrences listed in the DeepSource link (deepsource.io/gh/appsmithorg/appsmith/issue/JS 0458/occurrences/). Each occurrence points to a file and line number where an unused state definition is detected. For each case, verify that the state variable is indeed not used anywhere in the component or its children. If unused, remove the state definition and any associated setter calls. Ensure that the component still functions correctly by checking for any indirect usage. The repository is TypeScript based React, so look for useState calls in function components. The issue has an assignee, so coordinate if necessary.