apache/gravitino

[Improvement] Remove warnings when compiling Gravitino

Open

#1809 aperta il 31 gen 2024

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)Java (887 fork)auto 404
good first issueimprovement

Metriche repository

Star
 (3058 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

What would you like to be improved?

Warning shows up when compiling Gravitino, adding -Xlint:unchecked gives this:

> Task :common:compileJava FAILED
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:82: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(metalake.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:132: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(catalog.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:141: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(schema.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:167: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(table.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
error: warnings found and -Werror specified
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:90: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:101: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:112: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:123: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:86: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:97: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:108: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:119: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:112: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:123: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:134: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:145: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:156: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:167: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:86: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:97: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:108: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:119: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:141: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:152: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:163: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:174: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:185: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:190: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:164: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:175: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:186: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:197: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:208: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:213: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:218: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:223: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:228: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java:93: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java:98: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java:103: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
1 error
40 warnings

How should we improve?

Remove the warnings. This is required by https://www.bestpractices.dev/en

Guida contributor

Direzione di ricerca
Aggiungi parametri di tipo generico alle classi Builder in DTOConverters.java e nei file DTO (AuditDTO, MetalakeDTO, CatalogDTO, SchemaDTO, ColumnDTO, TableDTO, IndexDTO) per eliminare gli avvisi unchecked. Assicurati che il metodo withProperties e le istruzioni di cast utilizzino i tipi generici corretti.
Tech stack
java
Dominio
backend
Tipo issue
Refactoring
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
1
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
Meno di 1 ora
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Attiva
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
JavaGenerics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
80