antonio-ramadas/palbum

Refactor App.js

Aperta

#7 aperta il 12 mar 2019

 (0 commenti) (0 reazioni) (0 assegnatari)JavaScript (0 fork)auto 404
frontendgood first issue

Metriche repository

Star
 (9 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

App.js is doing more than it should. It populates the page (search bar and table).

However, whenever there is an update to the list (e.g., a new album is added) the whole component is rendered. As you can guess, there is no need for it.

Also, with a refactor, the logic would no longer be on a single file and its size will most likely be reduced.

I suggest having one component for the search bar, another for the table and App.js simply calls them on the rendermethod.

Guida contributor