ankidroid/Anki-Android

CI should test 16kb and non-16kb page alignment in libraries, packaging, and emulator

Open

Aperta il 20 ago 2024

Vedi su GitHub
 (13 commenti) (1 reazione) (1 assegnatario)Kotlin (11.132 star) (2789 fork)batch import
Blocked by dependencyCIHelp WantedTests

Descrizione

with upcoming need to be "16kb alignment clean" the CI matrix for emulator tests should be updated to run against a 16kb emulator as well as a regular emulator. Suggest using this API/image-name tuple:

android-35;google_apis_ps16k

The page size should be verified in CI prior to execution, via the tests on linked google doc

Additionally, the .apk should be extracted and have .so file verification of page-alignment checked, and finally the zipalign should be checked - otherwise we won't know if we have actually done the work or not, and we won't track any random regressions

Originally posted by @mikehardy in https://github.com/ankidroid/Anki-Android-Backend/pull/402#discussion_r1723732098

Guida contributor

Tech stack
kotlinandroid
Dominio
ci cdtesting
Tipo issue
test
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
4
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
active
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Android CIGitHub Actionspage alignment concepts
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
35
Direzione di ricerca
Start by examining the repository's CI workflow files, likely in .github/workflows. The issue references PR #402 in Anki Android Backend, which contains context on 16kb page alignment. The task involves adding an emulator test using the image 'android 35;google apis ps16k' and implementing checks for .so alignment and zipalign verification. Review the linked Google doc for the exact verification commands.