angular/components

Cdk Overlay backdrop does not respect noopanimations

Chiusa

#18.645 aperta il 28 feb 2020

Vedi su GitHubGuida contributor
 (1 commento) (0 reazioni) (0 assegnatari)TypeScript (6650 fork)batch import
GP4area: cdk/overlayhelp wanted

Metriche repository

Star
 (24.044 stelle)
Metriche merge PR
 (Merge medio 3g 12h) (98 PR mergiate in 30 g)

Descrizione

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/fork/components-issue

Steps to reproduce:

  1. import NoopAnimationsModule
  2. Create a dialog https://stackblitz.com/edit/angular-fdgmah (based on example dialog stackblitz)

Expected Behavior

What behavior were you expecting to see?

The dark overlay appears immediately with no animation

Actual Behavior

What behavior did you actually see?

The overlay backdrop fades in over 400ms.

Environment

  • Angular: 9.1
  • CDK/Material: 9.1
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Linux

Guida contributor

Direzione di ricerca
Investigate the CDK Overlay backdrop animation code in the Angular components repository, likely in packages/cdk/overlay/backdrop.ts or similar. Check if NoopAnimationsModule is properly propagated to the backdrop animation. Review the existing comment for any additional details. The fix may involve setting the animation state directly when noop animations are enabled.
Tech stack
typescript
Dominio
frontend
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
Mezza giornata
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Abbastanza chiara
Prerequisiti
Angular basicsCDK Overlay knowledgeAngular animations
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
30