angular/components

Overlay is not destroyed while navigating using Browser's Back/Forward button (RouteReuseStrategy is used)

Closed

#17.973 aperta il 16 dic 2019

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)TypeScript (6650 fork)batch import
P3area: cdk/overlayhelp wanted

Metriche repository

Star
 (24.044 star)
Metriche merge PR
 (Merge medio 2g 16h) (80 PR mergiate in 30 g)

Descrizione

Reproduction

https://angular-hlrhkp-pzxidw.stackblitz.io/

Steps to reproduce:

  1. Click on the navigate to second page link.
  2. Click on Browser Back Button and Open the select box .
  3. Click on the browser forward button to navigate.

Expected Behavior

What behavior were you expecting to see? The overlay of the previous component should be destroyed, when the browser navigation buttons clicked

Actual Behavior

What behavior did you actually see? The overlay of the material persists even after the page is routed to next page

Environment

  • Angular:
  • CDK/Material: 5.21
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows

Guida contributor

Direzione di ricerca
Investigate how Angular CDK overlay's lifecycle interacts with router navigation when RouteReuseStrategy is used. Look at the overlay ref counting mechanism in the OverlayRef and how it handles detach on route change. Check if there is a missing cleanup when the route is reused. Consider examining the following files: overlay ref.ts, overlay container.ts, and the RouterModule setup.
Tech stack
typescript
Dominio
frontend
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
4
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
3-5 giorni
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
Angular basicsAngular CDK OverlayRouteReuseStrategy
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
25