angular/components
Vedi su GitHub[Docs] More details on custom form field controls guide
Open
#13.624 aperta il 16 ott 2018
P3area: docsarea: material/form-fieldhelp wanted
Metriche repository
- Star
- (24.044 star)
- Metriche merge PR
- (Merge medio 2g 16h) (80 PR mergiate in 30 g)
Descrizione
Bug, feature request, or proposal:
I'd like to request a review of the 'Creating a custom form field control' guide as it does not cover enough in regards to each of it properties and opts to just mentioning them.
What is the expected behaviour?
Common examples that are detailed on other approaches and usages.
What is the current behaviour?
Common examples that are not all detailed on other approaches or usages.
What is the use-case or motivation for changing an existing behaviour?
My biggest gripe that pushed me to make this ticket is that of the error state.
Since we're not using an NgControl in this example, we don't need to do anything other than just set it to false.
Where as it should be like 'ngControl' which has sufficient methods of implementation
It is likely you will want to implement ControlValueAccessor ...
Is there anything else we should know?
Others have had the same issue