angular-ui/ui-grid

Grouppriority default treeAggregationFn overwrite bug

Open

#5123 aperta il 16 feb 2016

Vedi su GitHub
 (2 commenti) (1 reazione) (0 assegnatari)JavaScript (2496 fork)batch import
good first issuegrid-grouping

Metriche repository

Star
 (5395 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

According to the docs the groupingColumnBuilder function should get one of the default aggregations when the groupPriority is undefined or less then 0, however, in the code it does otherwise:

If the groupPriority is undefined or less than 0, then we expect to be aggregating, and we look at the aggregation types to determine what sort of aggregation we can do. Values are in the constants file, but include SUM, COUNT, MAX, MIN

if ( typeof(col.grouping.groupPriority) !== 'undefined' && col.grouping.groupPriority > -1 ){
    col.treeAggregationFn = uiGridTreeBaseService.nativeAggregations()[uiGridGroupingConstants.aggregation.COUNT].aggregationFn;
    col.treeAggregationFinalizerFn = service.groupedFinalizerFn;
}

As you see in the above code, it actually checks for !== 'undefined' && > -1, which overwrites a possible custom set treeAggregationFn with a default one.

This above code is taken from the current release, line #18959

Guida contributor