andywer/react-usestyles

Allow eager styles preparation

Aperta

#1 aperta il 11 nov 2018

 (2 commenti) (0 reazioni) (0 assegnatari)JavaScript (2 fork)github user discovery
enhancementhelp wanted

Metriche repository

Star
 (86 stelle)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

There are some opt-in options available to improve the performance, but there is one thing they cannot improve:

Every styles object has to be prepared initially and that happens each component mount. This preparation primarily means separation between static and dynamic style rules/declarations (function values).

Especially for components that get instantiated a lot that might have a serious performance impact.

Possible solution

Could pass a reference to the component to useStyles(), so the styles can be prepared only once for each component instead of once for each component instance.

import { useStyles } from "@andywer/style-hook"
import React from "react"

function Button () {
  const classNames = useStyles({
    default: {
      background: theme => props.background || theme.button.background.default
      // ...
    }
  }, Button, [props.background])
  return // ...
}

Additional benefit:

If we have the component reference, we have access to the component's name. Could use that for a better development / debugging experience (i.e. put component name on style tags).

Can also stop JSON.stringify()-ing the styles for deduplication when having a component reference. Will improve the overall performance even more!

Guida contributor