alibaba/nacos

make nacos-client sdk remove prometheus dependency and metrics with other way.

Open

Aperta il 12 mag 2022

Vedi su GitHub
 (10 commenti) (0 reazioni) (0 assegnatari)Java (32.948 star) (13.279 fork)batch import
area/Clientgood first issuekind/enhancement

Descrizione

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

提一个实际应用中碰到的一个小问题，nacos-client依赖了一个较低的prometheus版本，而且非可选，作为核心客户端sdk做到尽可能轻量级的依赖，或者一个Default实现，JMX等，如果需要prometheus，则由adapter或者另一个依赖完成，对sdk的依赖规范来讲，要多一次依赖去除和更新版本的引入，无法精简，期待一个精简的nacos-SDK。

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Guida contributor

Tech stack
java
Dominio
backendinfrastructure
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaMaven/GradleNacos client architecture
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
Start by examining the nacos client module's pom.xml to locate the Prometheus dependency. Then, design a metrics abstraction interface that can have multiple implementations (e.g., JMX, Micrometer). Remove the Prometheus dependency and implement a default JMX based metrics reporter. Ensure backward compatibility for users who rely on Prometheus metrics by providing an optional adapter module. Review comments on the issue for additional context.