alibaba/Sentinel

*bug report* ProcessorSlot的Spi中的isSingleton = false设置不生效

Open

Aperta il 29 dic 2022

Vedi su GitHub
 (4 commenti) (0 reazioni) (0 assegnatari)Java (23.109 star) (8150 fork)batch import
area/spigood first issue

Descrizione

Issue Description

Type: bug report

Describe what happened (or what feature you want)

当在非单例模式的ProcessorSlot（A）前加一个单例模式的ProcessorSlot（B）后，所有ProcessorSlotChain中B的next都会同步修改为最新创建的A

Describe what you expected to happen

在上述行为后，不同的ProcessorSlotChain中B的next应该为各自新创建的A，而非共同的A

How to reproduce it (as minimally and precisely as possible)

  1. 添加一个ProcessSlot实现类，添加注解@Spi(order = Spi.ORDER_HIGHEST)

Tell us your environment

sentinel 1.8.3

Anything else we need to know?

DefaultProcessorSlotChain中添加next的方式是直接修改传入的AbstractLinkedProcessorSlot，但是传入的ProcessorSlot有可能是单例或非单例，倘若是单例，则在其后添加next会影响所有的ProcessorSlotChain

Guida contributor

Tech stack
java
Dominio
backend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
JavaSentinelSPI
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
30
Direzione di ricerca
The bug is about ProcessorSlot SPI singleton setting not taking effect when a non singleton ProcessorSlot (A) is preceded by a singleton ProcessorSlot (B). The issue is in DefaultProcessorSlotChain where adding a next node directly modifies the AbstractLinkedProcessorSlot, causing all chains sharing the singleton B to have the same next reference. Investigate the SPI annotation 'isSingleton' handling and the Chain's addLast method. Look at how ProcessorSlotChain constructs and links slots, and propose a fix to properly handle singleton vs non singleton slots when building chains.