alibaba/Sentinel
Vedi su GitHubDashboard Spring Boot Configuration more flexible support
Open
#2053 aperta il 27 feb 2021
area/dashboardgood first issuekind/enhancement
Metriche repository
- Star
- (23.109 star)
- Metriche merge PR
- (Nessuna PR mergiata in 30 g)
Descrizione
Issue Description
Type: feature request
Describe what happened (or what feature you want)
Make dashboard more extensible.
Describe what you expected to happen
Spring Boot Configuration more flexible
Use @ConditionalOnMissingBean not @Component directly, combine with @Configuration to create a bean.
For example, about MachineDiscovery.
We can write code like follow
@Configuration
public class MachineDiscoveryConfiguration {
@Bean
@ConditionalOnMissingBean
public SimpleMachineDiscovery simpleMachineDiscovery() {
return new SimpleMachineDiscovery();
}
@Bean
@ConditionalOnMissingBean
public AppManagement appManagement(SimpleMachineDiscovery simpleMachineDiscovery) {
return new AppManagement(simpleMachineDiscovery);
}
}
And delete annotation @Component above class SimpleMachineDiscovery and AppManagement.
If someone want to custom their AppManagement, that will make it more easy.
Same principle can apply to RuleRepository, DynamicRuleProvider, DynamicRulePublisher too.