alanshaw/david-www

Badge colour always green when all dependencies pinned

Open

#48 aperta il 16 lug 2013

Vedi su GitHub
 (2 commenti) (2 reazioni) (0 assegnatari)JavaScript (177 fork)batch import
bughelp wantedquestion

Metriche repository

Star
 (733 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

At the moment David considers tags, absolute versions (i.e. not semver ranges) and URLs as pinned dependencies. The idea being that the author wants to use a specific version because higher versions don't contain the same functionality (the author doesn't have a choice not to use the dependency at that version) or because it is a custom build of the module (for a URL dependency) or for some other reason. Pinned dependencies don't normally count towards your David badge, but when an author has pinned all dependencies to specific versions the reasoning behind not counting pinned dependencies towards your badge is incorrect, since if all dependencies are pinned the badge will always be green.

I propose that when all dependencies are pinned, absolute versions should affect the David badge colour.

Guida contributor